Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize project structure #7

Closed
wants to merge 1 commit into from

Conversation

jessemyers
Copy link

  • Use our standard babel and eslint configuration
  • Fix all resulting linting violations
  • Move tests to __tests__ directoeries
  • Update circle configuration

"plugins": [
"transform-decorators-legacy",
"transform-class-constructor-call"
"transform-decorators-legacy",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need decorators for now.

@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2017 Avi Zurel
Copyright (c) 2018 Globality, Inc.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha ha @KensoDev

 - Use our standard babel and eslint configuration
 - Fix all resulting linting violations
 - Move tests to `__tests__` directoeries
 - Update circle configuration
"regenerator-runtime": "^0.10.5"
}
"name": "nodule-config",
"version": "1.0.9",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will probably bump to 2.0.0, but I need to assess API changes first

@@ -0,0 +1,26 @@
import { isBoolean, parse } from '../booleanParser';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code changes are one of:

  • Proper function declarations and/or lambdas that pass eslint
  • Single quotes
  • Four space indent


appName = () => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style of class member function required another babel plugin; I don't see the point

@jessemyers jessemyers closed this Mar 26, 2018
@jessemyers jessemyers deleted the feature/modernize-structure branch March 26, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants