find_by modifies argument

[astudnev]

argument to find_by is modified now by method

At least 2 tests now fail:

term = model.find_by(attrs) || model.create!(attrs)

term = model.find_by( non_modifiable_hash )

This may be related to #282

[shioyama]

Can you write a test for this?

Yes globalize does modify the attributes, that's not a bug. But we hadn't considered non-modifiable hashes.

[shioyama]

Here's the relevant code: https://github.com/globalize/globalize/blob/master/lib/globalize/active_record/relation.rb#L54

[shioyama]

Actually this is a good catch, thanks. We just need to dup the hash before modifying it. If you have time a PR with the fix + a test would be great, otherwise I'll do it soon.

BTW this is not a problem only with find_by but with all methods overidden in relation.rb: where, etc.

[shioyama]

Try the branch I just created:

gem 'globalize', github: 'globalize/globalize', branch: 'issue_284_find_by_arguments'

This should fix the modifying arguments issue.

[shioyama]

This also seems to fix #283 , if so I'll just write a test for that and close both issues.

[astudnev]

i tested with gem 'globalize', github: 'globalize/globalize', branch: 'issue_284_find_by_arguments'
and it works OK for #284 #283