-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 5.2+ breaks Rails Admin integration #734
Comments
Did a little bit of digging and it appears that this is directly related to this change: 6356f95#diff-a4e451ff8babf2969ff95b0205af6dd1R78 When we set autosave to true, things start working. But when autosave is false it doesn't work. Is it possible that we could make autosave configurable? Would a PR be accepted? |
Submitted a pull request: #736 I can backfill specs if this PR seems reasonable and will be accpted. |
We noticed this change in behavior too when updating to 5.3.0 (we are not using rails_admin). You can work-around this problem without patching globalize by adding the following to your model: accepts_nested_attributes_for :translations This automatically sets autosave to true on the translations association. |
#736 was merged |
It appears there was a change in 5.2.0 that broke integration with rails_admin. I am able to load the translations in the interface just as before, but saving the record does not persist any changes to the translations to the DB, nor will it persist any newly created translations. Happy to provide whatever additional information is needed, but repro steps are fairly simple.
Globalize 5.3.0
RailsAdmin 1.4.2
Below is a sample configuration for a model that has a
name
, and a translated field ofdisplay_name
The text was updated successfully, but these errors were encountered: