To make uniqueness validator work with squeel (Rails 3.0) #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/activerecord-hackery/squeel#symbols-as-the-value-side-of-a-condition-in-normal-where-clauses "If you have any where() clauses that use a symbol as the value side (right-hand side) of a condition, you will need to change the symbol into a string in order for it to continue to be treated as a value."
|
I don't see a problem with this, except that the tests are failing but this doesn't seem to be your fault. |
parndt
added a commit
that referenced
this pull request
Apr 23, 2015
To make uniqueness validator work with squeel (Rails 3.0)
|
@torumori which version are you using? Do you want a new gem release? |
|
@parndt Thank you for your quick response! |
|
@torumori thanks for fixing it! Version 3.0.5 has been released to https://rubygems.org/gems/globalize/versions/3.0.5 |
|
@parndt thank you much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this to be fixed although 3-0-stable might be already out of support, but without this change, it causes ActiveRecord::StatementInvalid exception if the application uses squeel gem and the translated model uses the uniqueness validation.
https://github.com/activerecord-hackery/squeel#symbols-as-the-value-side-of-a-condition-in-normal-where-clauses
"If you have any where() clauses that use a symbol as the value side (right-hand side) of a condition, you will need to change the symbol into a string in order for it to continue to be treated as a value."