Support ruby 3.2 rails 7.1 #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ruby 3.2 was released at 2022/12/25 - Rails 7.1 was released at 2023/10/05
I don't know why "MiniTest" worked before.
i18n library specs have changed, old i18n gem returns "translation missing" but recent one returns "Translation missing".
CI fails with rails 7.1 like following
```
/home/runner/work/globalize/globalize/vendor/bundle/ruby/3.2.0/gems/activerecord-7.1.0/lib/active_record/connection_adapters/abstract/schema_statements.rb:1778:in `validate_table_length!': Table name 'migrated_with_mega_ultra_super_long_model_name_with_more_then_sixty_characters' is too long; the limit is 64 characters (ArgumentError)
raise ArgumentError, "Table name '#{table_name}' is too long; the limit is #{table_name_length} characters"
```
We need to skip creating a long name table with rails 7.1 due to rails/rails#45136
|
Thanks this look good but, forgive my ignorance, when did |
|
s/MiniTest/Minitest/ change seems to be done at minitest 5.0 |
parndt
approved these changes
Oct 11, 2023
|
thank you 🌈 |
|
Hi 👋 Thanks for the work on globalize, when do you think a release might happen ? The current latest gem version prevents upgrading to rails 7.1 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ruby 3.2 and Rails 7.1 to CI and make it work where it didn't work
CI result is here.