Update go version to 1.22.1 and run go mod tidy #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github workflow for Go has been updated as well to avoid checking development branch since we've been just merging directly to master. Go versions 1.16-1.22 are being check, 1.13-1.15 have been dropped.
|
Need to get MacOS tests working |
On different platforms the error message for the underlying TLS library may differ. The message may also change between versions. In order to support multiple platforms and versions, the TestCACerts test case may now accept multiple errors messages to match against, only needing one to match to satisfy the test case.
toddgaunt-gs
requested review from
kingcdavid,
laurence-pawling,
tembio,
angela-globalsign,
mara-soldan and
eliot-gs
| t.Fatalf("got %v, want no error", got) | ||
| } | ||
|
|
||
| // got != nil && len(wants) > 0 |
There was a problem hiding this comment.
This was intentional, as it is documenting which case this is for.
| contains := false | ||
| for _, w := range wants { | ||
| if strings.Contains(got.Error(), w.Error()) { | ||
| contains = true |
There was a problem hiding this comment.
you can break here if you like.
angela-globalsign
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github workflow for Go has been updated as well to avoid checking development branch since we've been just merging directly to master. Go versions 1.21-1.22 are being checked, 1.13-1.20 have been dropped due to incompatibility with the new go.mod version format (X.Y.Z rather than X.Y).