Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Overview section #56

Merged
merged 2 commits into from Nov 1, 2020
Merged

Create Overview section #56

merged 2 commits into from Nov 1, 2020

Conversation

yoyo-go
Copy link
Contributor

@yoyo-go yoyo-go commented Oct 24, 2020

Add a brief intro of wordnet.

@yoyo-go
Create Overview section
d058879 
Add a brief intro of wordnet.
@yoyo-go
Copy link
Contributor Author

yoyo-go commented Oct 24, 2020

Please let me know if you think more topic needs to be added to this section.

@fcbond
Copy link
Member

fcbond commented Oct 30, 2020

This helps a lot in giving some idea of what is going on.

I think it is important to format a bit more for readability. Words being mentioned should be italicized and ideally linked to wordnet: "such as shut and close".

We should also link to at least Princeton Wordnet and the Open Multilingual Wordnet.

@yoyo-go
Add Princeton Wordnet and OMW
d18586d 
Add Princeton Wordnet and OMW into the overview section.
@yoyo-go
Copy link
Contributor Author

yoyo-go commented Oct 31, 2020

This helps a lot in giving some idea of what is going on.

I think it is important to format a bit more for readability. Words being mentioned should be italicized and ideally linked to wordnet: "such as shut and close".

We should also link to at least Princeton Wordnet and the Open Multilingual Wordnet.

The links have been added, please let me know if you think any info is still missing in this section.

@fcbond fcbond merged commit 2cce752 into globalwordnet:gsod Nov 1, 2020
@fcbond
Copy link
Member

fcbond commented Nov 1, 2020

Looks good to me! Closes #54.

@fcbond fcbond mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcbond fcbond Awaiting requested review from fcbond

@goodmami goodmami Awaiting requested review from goodmami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoyo-go @fcbond