Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page updates #33

Merged
merged 9 commits into from
May 19, 2022
Merged

Settings page updates #33

merged 9 commits into from
May 19, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 19, 2022

Description of the Change

  • Settings section changed to "Debug Bar Settings"
  • "Enable Logging" checkbox name and label are updated
  • "View logs" link only visible when logs are enabled AND logs directory is writable
  • Link to logs in Tools menu only visible when logs are enabled
  • Tools menu link and page name include "Sophi.io"
  • Fixed missing textdomain in Logs page title

Closes #18
Closes #19

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Tweak - Settings page updates
Fix - missing text domain for "Sophi.io Logs" page title

Credits

Props @cadic

@cadic cadic added this to the Future Release milestone May 19, 2022
@cadic cadic requested a review from jeffpaul May 19, 2022 07:30
@cadic cadic self-assigned this May 19, 2022
@jeffpaul jeffpaul modified the milestones: Future Release, 0.3.0 May 19, 2022
@jeffpaul jeffpaul merged commit 16ea24c into develop May 19, 2022
@jeffpaul jeffpaul deleted the enhancement/settings-updates branch May 19, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug log setting updates Update settings section from Debug to Debug Bar settings
2 participants