Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Quick Edit compatibility with Yoast #110

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

We have another compatibility issue with Yoast. In #107, we fixed the publishing issue when Yoast SEO is activated but also introduced another issue, update events through Quick Edit aren't sent to Sophi. This PR fixes this issue by detecting events through Quick Edit.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fixed: update events via Quick Edit are not being sent to Sophi when Yoast SEO is activated.

@dinhtungdu dinhtungdu requested a review from dkotter July 24, 2021 16:22
@dinhtungdu dinhtungdu self-assigned this Jul 24, 2021
@dinhtungdu dinhtungdu added the bug Something isn't working label Jul 24, 2021
@dinhtungdu dinhtungdu added this to the 1.0.4 milestone Jul 24, 2021
@@ -79,6 +79,16 @@ function track_event( $new_status, $old_status, $post ) {
}

if ( class_exists( 'WPSEO_Meta' ) ) {
// Detech if the current request comes from Quick Edit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small type here. Should be Detect

dkotter
dkotter previously approved these changes Jul 24, 2021
@jeffpaul jeffpaul merged commit b46d30b into develop Jul 26, 2021
@jeffpaul jeffpaul deleted the fix/yoast-compat-quick-edit branch July 26, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants