Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name convention for appId #117

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Change name convention for appId #117

merged 1 commit into from
Aug 17, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Aug 16, 2021

Description of the Change

This change updates the name convention from -website, -cms, and -amp to :website, :cms, and :amp.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@Rahmon Rahmon self-assigned this Aug 16, 2021
@jeffpaul jeffpaul added this to the 1.1.0 milestone Aug 16, 2021
@Rahmon Rahmon requested a review from felipeelia August 17, 2021 12:38
dinhtungdu
dinhtungdu approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rahmon Rahmon merged commit e49586a into develop Aug 17, 2021
@Rahmon Rahmon deleted the chore/change-naming-conventions-for-appId branch August 17, 2021 15:35
@jeffpaul
Copy link
Contributor

Note that this related to https://voltron.atlassian.net/servicedesk/customer/portal/41/SIT-2305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia approved these changes

@dinhtungdu dinhtungdu dinhtungdu approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

Assignees

@Rahmon Rahmon

Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Rahmon @jeffpaul @felipeelia @dinhtungdu