Fix mongoDB not updating if internaldepURL changes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaveira3
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Nice, @Krlier! I have tested your branch and it worked fine! Thanks for this. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293
This PR aims to fix a bug in which
internaldepURLwould not be updated if the desired repository to be analyzes was already present in the database.api/db/huskydb.go: AddinternaldepURLto the insert analysis struct.api/log/messagecodes.go: Add a new message code if huskyCI wasn't able to update a repository with a newinternaldepURL.api/routes/analysis.go: Add logic to update the database ifinternaldepURLvalue changes.api/types/types.go: Addomitemptytag sointernaldepURLwon't show up in the database unless it's not empty.