Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update security tests each time huskyCI starts #302

Merged
merged 1 commit into from Jul 17, 2019
Merged

Update security tests each time huskyCI starts #302

merged 1 commit into from Jul 17, 2019

Conversation

spimpaov
Copy link
Contributor

@spimpaov spimpaov commented Jul 17, 2019 •
edited

Closes #271

Adds UpdateOneDBSecurityTest() step to checkSecurityTest() function, forcing the app to update each security test with the contents from config.yaml file each time huskyCI starts.

@spimpaov spimpaov requested a review from rafaveira3 July 17, 2019 18:13
@spimpaov spimpaov changed the title WIP: Update sec tests each time app starts api|FEAT: Update sec tests each time app starts Jul 17, 2019
@rafaveira3 rafaveira3 changed the title api|FEAT: Update sec tests each time app starts Update security tests each time huskyCI starts Jul 17, 2019
@spimpaov spimpaov changed the title Update security tests each time huskyCI starts api|FEAT: Update security tests each time huskyCI starts Jul 17, 2019
@rafaveira3 rafaveira3 changed the title api|FEAT: Update security tests each time huskyCI starts Update security tests each time huskyCI starts Jul 17, 2019
@spimpaov spimpaov added the feature Add a new feature label Jul 17, 2019
rafaveira3
rafaveira3 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@rafaveira3 rafaveira3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great, @Takehime! Thanks for this contribution! 🚀

@rafaveira3 rafaveira3 merged commit 187287a into master Jul 17, 2019
@rafaveira3 rafaveira3 deleted the sectests branch July 17, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaveira3 rafaveira3 rafaveira3 approved these changes

Assignees
No one assigned
Labels
feature Add a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force huskyCI add all securityTest config into MongoDB every time it starts
2 participants
@spimpaov @rafaveira3