Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn gitleaks timeout into a low vuln #454

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Turn gitleaks timeout into a low vuln #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions api/securitytest/gitleaks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func analyseGitleaks(gitleaksScan *SecTestScanInfo) error {
return nil
}

// if gitleaks timeout, a warning will be generated as a nosec vuln
// if gitleaks timeout, a warning will be generated as a low vuln
gitleaksTimeout := strings.Contains(gitleaksScan.Container.COutput, "ERROR_TIMEOUT_GITLEAKS")
if gitleaksTimeout {
gitleaksScan.GitleaksTimeout = true
Expand Down Expand Up @@ -83,21 +83,21 @@ func (gitleaksScan *SecTestScanInfo) prepareGitleaksVulns() {
gitleaksVuln := types.HuskyCIVulnerability{}
gitleaksVuln.Language = "Generic"
gitleaksVuln.SecurityTool = "Gitleaks"
gitleaksVuln.Severity = "nosec"
gitleaksVuln.Severity = "low"
gitleaksVuln.Details = "It looks like your project is too big and huskyCI was not able to run Gitleaks."

gitleaksScan.Vulnerabilities.NoSecVulns = append(gitleaksScan.Vulnerabilities.NoSecVulns, gitleaksVuln)
gitleaksScan.Vulnerabilities.LowVulns = append(gitleaksScan.Vulnerabilities.LowVulns, gitleaksVuln)
return
}

if gitleaksScan.GitleaksErrorRunning {
gitleaksVuln := types.HuskyCIVulnerability{}
gitleaksVuln.Language = "Generic"
gitleaksVuln.SecurityTool = "Gitleaks"
gitleaksVuln.Severity = "nosec"
gitleaksVuln.Severity = "low"
gitleaksVuln.Details = "Internal error running Gitleaks."

gitleaksScan.Vulnerabilities.NoSecVulns = append(gitleaksScan.Vulnerabilities.NoSecVulns, gitleaksVuln)
gitleaksScan.Vulnerabilities.LowVulns = append(gitleaksScan.Vulnerabilities.LowVulns, gitleaksVuln)
return
}

Expand Down