-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for custom tags #130
Add basic support for custom tags #130
Conversation
I have another idea here: we can add the "ignored" tags in a new data structure, containing the ...
elif line.startswith('#'):
data['ignored_lines'] = {'line': line, 'lineno': lineno}
...
# Usage
m3u8_obj = m3u8.loads('#EXTM3U8 ... etc ... ')
data = post_process_data(m3u8_obj.data) |
Main parser function now receives a function that can be used to parse the line content and save it into the data store object.
4e5675c
to
5f40195
Compare
LGTM and solves #123 and #124 does all the tests pass locally @mauricioabreu ? I tried to restart the build manually but the same error happened
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix build
@leandromoreira I was reading about this error and it seems to be incompatibility of |
Python 3.5 and Python 2.6 passed the test suite: https://travis-ci.org/globocom/m3u8/builds/485545837?utm_source=github_status&utm_medium=notification |
so I'll merge it and then I'll try to use this tox thing. |
@leandromoreira we don't pin versions of any dependence. Recently
Maybe |
We should do this. |
good catch |
Main parser function now receives a function that can be
used to parse the line content and save it into the data store object.