Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustness fix to _parse_extinf #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

robustness fix to _parse_extinf #16

wants to merge 1 commit into from

Conversation

deutrino
Copy link

@deutrino deutrino commented Oct 6, 2012

function now handles titles with commas, and coerces unset durations to 0

@jbochi
Copy link
Contributor

jbochi commented Oct 8, 2012

Thanks for the pull-request, but I think we should not merge it as it is.

  1. I think the solution for titles with commas is ok, but we should add a test case.

  2. The spec does not mention how blank durations should be handled, but I think we should set it to None internally, so we can dump it as blank and not 0. Tests would be nice two.

@feuvan
Copy link
Contributor

feuvan commented Jan 17, 2013

Just follow the same way using ATTRIBUTELISTPATTERN should be ok.
see _parse_stream_inf and _parse_key

@leandromoreira
Copy link
Contributor

@jbochi @feuvan and @gordon-morehouse is it still valid to apply or should we wait for test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants