-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend custom_tags_parser functionality #247
Extend custom_tags_parser functionality #247
Conversation
This PR is ready for review and merging. Please, highlight in release notes, that there is a breaking change: |
6fdd116
to
c0b84cc
Compare
@leandromoreira @mauricioabreu |
@SerhiyRomanov sorry for delay I'll try to read all the PR :) thanks again, you're always helping a lot. |
that's wonderful @SerhiyRomanov I'll try to reach @mauricioabreu so we can seep up your work to be released as soon as possible. |
I think, next relase we may need to bump up major version @mauricioabreu , @SerhiyRomanov do you agree? |
@SerhiyRomanov there's still conflicts can you resolve them? |
c0b84cc
to
648c33a
Compare
@leandromoreira I've resolved conflicts, so it can be merged. Let me know if I can help more with that library. |
thanks a lot, @mauricioabreu and I are planning to release a new version before your changes and a new major after merging your work. |
@SerhiyRomanov good job! I want to merge this but there are some tests failing. Can you check it? Are those tests failing for you too? |
Added the ability to control whether should 'main' go to next line or not after custom_tags_parser has finished The Segment class has been extended for storing custom values
49422ac
to
5c641f1
Compare
@mauricioabreu I fixed the tests, could you run the test suite one more time? |
Thank you @SerhiyRomanov |
What have been already implementing:
Example of new custom_tags_parser function, which allow parsing the playlist above