Handle SCTE-35 Enhanced EXT-X-ASSET tags #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
commented
Aug 16, 2022
| @@ -711,6 +711,7 @@ | |||
| #EXTINF:2.040, | |||
| master2500_47226.ts | |||
| #EXT-OATCLS-SCTE35:/DAlAAAAAAAAAP/wFAUAAAABf+//wpiQkv4ARKogAAEBAQAAQ6sodg== | |||
| #EXT-X-ASSET:GENRE=CV,CAID=12345678,EPISODE="Episode%20Name%20Date",SEASON="Season%20Name%20and%20Number",SERIES="Series%2520Name" | |||
There was a problem hiding this comment.
This is the example given here.
bbayles
commented
Aug 16, 2022
| '#EXT-X-CUE-OUT-CONT' | ||
| ) | ||
| assert cue_out_cont_line not in result | ||
| assert result.count(cue_out_line) == 1 |
There was a problem hiding this comment.
The earlier version of this test meant to test that the EXT-OATCLS-SCTE35 tag wasn't repeated and didn't need to dictate the exact ordering of tags.
|
Excellent! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the "SCTE-35 Enhanced" support added in #288 and #290. Elemental's documentation details their expectations for the
EXT-X-ASSETtag here and here.