Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Add default duration #343

Closed
wants to merge 1 commit into from
Closed

[POC] Add default duration #343

wants to merge 1 commit into from

Conversation

radujica
Copy link

@radujica radujica commented Nov 9, 2023

No description provided.

@radujica radujica mentioned this pull request Nov 9, 2023
Closed
@mauricioabreu
Copy link
Member

Hello @radujica

Duration of a data segment should be mandatory. I'm not a big fan of adding default values. What is your opinion @leandromoreira ?

@mauricioabreu
Copy link
Member

I think the best option here is adding a better message. Since this library is a parser, we should not be adding default values. I hope you understand it.

@radujica radujica deleted the fix/default_duration branch August 1, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radujica @mauricioabreu