Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for headers to URL opener #95

Merged
merged 3 commits into from
Jan 19, 2017
Merged

Add support for headers to URL opener #95

merged 3 commits into from
Jan 19, 2017

Conversation

baco
Copy link
Contributor

@baco baco commented Jan 19, 2017

Added the ability to build the request for an URL specifying more
arguments such as headers. With this option cookies, referrer and
user-agent may be passed to access the content of URLs.

Closes: #94, #82

@baco
Add support for headers to URL opener
4e843c9 
Added the ability to build the request for an URL specifying more
arguments such as headers.  With this option cookies, referrer and
user-agent may be passed to access the content of URLs.
@leandromoreira
Copy link
Contributor

Thank you @baco I'd ask you though to add some tests and also to fix the current build

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.935% when pulling 9dfb596 on baco:http-headers into 2e5d867 on globocom:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.935% when pulling 9dfb596 on baco:http-headers into 2e5d867 on globocom:master.

@baco
Use the created request among all connections
d7514f9 
Once built the request use it every time urlopen() is called instead of
uri.
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 95.968% when pulling d7514f9 on baco:http-headers into 2e5d867 on globocom:master.

leandromoreira
leandromoreira approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@leandromoreira leandromoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @baco

@leandromoreira leandromoreira merged commit b254caf into globocom:master Jan 19, 2017
@mauricioabreu mauricioabreu mentioned this pull request Feb 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandromoreira leandromoreira leandromoreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baco @leandromoreira @coveralls @hbdjlong