Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mispositioning toolbar #291

Closed
mogavin opened this issue Dec 20, 2019 · 4 comments
Closed

Mispositioning toolbar #291

mogavin opened this issue Dec 20, 2019 · 4 comments
Labels

Comments

@mogavin
Copy link
Contributor

mogavin commented Dec 20, 2019

Obs: For easier tracking, we've grouped issues related to mispositioning toolbar.

Related issues

#251
#239
#199
#143

Related PR's

#258
#294

Expected Behavior

When the toolbar encounters a border, it must be repositioned.

image

Current Behavior

When the toolbar encounters a border, it does not reposition and appears cut off.

image

@mogavin mogavin added the bug label Dec 20, 2019
@mogavin mogavin changed the title Toolbar gets cut off Mispositioning toolbar Dec 20, 2019
@wdtamagi
Copy link
Contributor

wdtamagi commented Jan 4, 2020

I sent a PR to fix this.

@wdtamagi
Copy link
Contributor

wdtamagi commented Jan 5, 2020

I believe there is a conflict with Codacy (pipeline) rules and eslint rules for semicolons on my PR #294

@mogavin
Copy link
Contributor Author

mogavin commented Jan 6, 2020

Thank you for your contribution, @wdtamagi . We will look at the issues raised and we will give you feedback shortly.

@mogavin
Copy link
Contributor Author

mogavin commented Feb 17, 2020

Merged in release 0.7.0-alpha.0

@mogavin mogavin closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants