Mispositioning toolbar

[wdtamagi]

fix for #291

This PR fix toolbar position for highest left and right.

[wdtamagi]

I don't understand the issues of Codacy...

[wdtamagi]

The Codacy rule is without semi and the eslint.prettier/prettier rule is with semi...

[mogavin]

An arrow spacing is occurring when the prop movableBlocks from MegadraftEditor is false. Could you please check?

[wdtamagi]

@mogavin Sure i will work on this fix, thanks for your reply.
And about Codacy issues?

[mogavin]

Thanks, @wdtamagi ! We will also check Codacy issues

[wdtamagi]

@mogavin Can you check again?

[mogavin]

The feature looks fine now, but one of the tests is not passing ( make test command )

P.S: We still analysing de Codacy issue 👍

[wdtamagi]

Ops, sorry about that.
I will work on this.
Thanks @mogavin

[mogavin]

@wdtamagi, Codacy is ok now 👍

[wdtamagi]

@mogavin
I fixed the test, but I don't understand the method "replaceSelection" not really replace the mocked selection...

[mogavin]

Thanks, @wdtamagi. As for replaceSelection method, I didn't understand your question. Could you detail it better?

[wdtamagi]

In the toolbar test have a method:

const replaceSelection = (newSelection, wrapper) => {
  const selectionState = SelectionState.createEmpty("ag6qs");
  const updatedSelection = selectionState.merge(newSelection);
  const oldState = wrapper.state("editorState");

  const editorState = EditorState.forceSelection(oldState, updatedSelection);

  wrapper.setState({ editorState: editorState });
};

This method mock the editorState of component, but all the math for calculate the position of toolbar use de DOM elements (src/utils.js method getSelectionCoords).

I believe for a really useful test of positioning of toolbar need mock the DOM position of editor for make things happen.

I can try do this on this PR or in another one.

[mogavin]

@wdtamagi
I believe the objective of method replaceSelection is to change the selectionState portion of editorState, which influences the return of method getVisibleSelectionRect (used in getSelectionCoords). But any suggestions for improvement will be very welcome, thanks for your contribution!

[KyleLawson16]

This seems to have stopped the toolbar from going out of view of the window, however now I'm seeing an issue with positioning of the toolbar with selected text on the left side of the editor. Running v0.7.0

[mogavin]

Hi @KyleLawson16 ! Yep, we have become aware of this problem recently. We will soon work on a correction ( but, as always, we are open to contributions too 😀 ). Thanks !

[KyleLawson16]

Hey @mogavin I was able to find some time to tackle it #310

[mogavin]

Great, @KyleLawson16! We will review this PR and provide feedback soon. Thanks !