Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding variables for colors and @media queries #363

Merged
merged 8 commits into from
Feb 9, 2022

Conversation

laisfrigerio
Copy link
Contributor

Proposed Changes

  • Added _colors.scss file into src/styles;
  • Added _colors.scss file into website/styles;
  • Added css colors into variables;
  • Added @media queries into variables;

Colors are named as ‘color-XX’ (for ex. blue-100), while the ‘XX’ number represents different shades

Copy link
Contributor

@vitorhugomattos vitorhugomattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi! thanks for your PR! it looks like your code brought up an error in our codebase and so the Sass compiler is not able to compile the library code. can you fix it so I can merge your branch? just change the line 42 in gulpfile.js (source should be ./src/styles/megadraft.scss). I also noticed that you forgot to create the variable for black color in the new library colors partials file and this is also preventing the compilation.

@laisfrigerio
Copy link
Contributor Author

Hi, @vitorhugomattos Sorry for to late. I fixed the gulpfile.js and added $black variable into _colors.scss file. If something is still incorrect, please, let me know.

@marcelometal
Copy link
Member

marcelometal commented Jan 16, 2022

Hi @laisfrigerio,

There are other variables, such as:

You can use something like the command line below to find the missing variables:

for X in $(find . -name "*.scss"); do echo $X; grep color $X | grep -v \\$; done

@marcelometal
Copy link
Member

Thank you @laisfrigerio and @vitorhugomattos ! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants