-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding variables for colors and @media queries #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi! thanks for your PR! it looks like your code brought up an error in our codebase and so the Sass compiler is not able to compile the library code. can you fix it so I can merge your branch? just change the line 42 in gulpfile.js
(source should be ./src/styles/megadraft.scss
). I also noticed that you forgot to create the variable for black color in the new library colors
partials file and this is also preventing the compilation.
Hi, @vitorhugomattos Sorry for to late. I fixed the |
Hi @laisfrigerio, There are other variables, such as:
You can use something like the command line below to find the missing variables: for X in $(find . -name "*.scss"); do echo $X; grep color $X | grep -v \\$; done |
5f31f04
to
7b05c64
Compare
7b05c64
to
394ee1b
Compare
Thank you @laisfrigerio and @vitorhugomattos ! =) |
Proposed Changes
_colors.scss
file intosrc/styles
;_colors.scss
file intowebsite/styles
;Colors are named as ‘color-XX’ (for ex. blue-100), while the ‘XX’ number represents different shades