Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting at scale #7

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Alerting at scale #7

merged 3 commits into from
Dec 19, 2019

Conversation

wpjunior
Copy link
Member

Based on lessons of https://landing.google.com/sre/workbook/chapters/alerting-on-slos/#alerting_at_scale

The initial motivation is to standardize a set of SLOs and help teams to classify many microservices without pain.

Could you review? @vierno, @pedrokiefer, @MayconDionisio

@vierno
Copy link
Member

vierno commented Dec 18, 2019

@wpjunior, I have a suggestion: if you could write a some inline docs and comments, it would help those reading the code.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
slo/classes.go Outdated Show resolved Hide resolved
slo/classes.go Outdated Show resolved Hide resolved
@wpjunior
Copy link
Member Author

Thanks, @vierno for your given review.

@wpjunior wpjunior merged commit 25ecbff into master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants