PIL Engine: save image optimized otherwise save image without enhancement #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some large JPEG images (say 3000x3000) would trigger an IOError exception when PIL engine is storing the image. The solution is to increase ImageFile.MAXBLOCK. This modification allows to save the image without enhancement when it is bigger than ImageFile.MAXBLOCK, so the image is stored anyway, but it logs a message in order to hint one to increase the value of ImageFile.MAXBLOCK for fine tuning.
|
Great! Looks fine to me since the validation for image size is done before these lines. Looks safe and will improve the successfully responses. Thank you @ruda |
heynemann
added a commit
that referenced
this pull request
Sep 22, 2011
PIL Engine: save image optimized otherwise save image without enhancement
|
Thank you. |
|
Not at all! Thank you! Whenever you need any help, just let us know. And Cheers, On Sat, Sep 24, 2011 at 7:27 PM, Rud Moura <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some large JPEG images (say 3000x3000) would trigger an IOError
exception when PIL engine is storing the image. The solution is to
increase ImageFile.MAXBLOCK. This modification allows to save the image
without enhancement when it is bigger than ImageFile.MAXBLOCK, so the
image is stored anyway, but it logs a message in order to hint one to
increase the value of ImageFile.MAXBLOCK for fine tuning.