Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections #162

Closed
wants to merge 4 commits into from
Closed

Collections #162

wants to merge 4 commits into from

Conversation

NickolausDS
Copy link
Collaborator

No description provided.

… portals'

This feature adds the ability to specify COLLECTIONS in settings.py to allow
users to browse files on a Globus Endpoint.
…rview

Overview loads a bit faster, so this is more desirable.
except Exception:
log.error('Encountered error on operation_ls API!', exc_info=True)
return JsonResponse({'message': 'Unexpected Error, this is a bug!'},
status=500)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this code should be generalized. Currently, this allows the frontend to call operation_ls using only the users active Django login session and without touching a Globus Transfer access token.

An alternative is making a server-side API where the frontend can request tokens, and the frontend could then make requests as needed.


CollectionSelector.prototype.joinUnix = function(paths) {
return paths.join('/').replace('//', '/')
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove the calls to JQuery just for good measure. I think it's good practice to not use JQuery where it isn't needed.

Additionally, I think this would benefit from a proper javascript paths module for handling Unix paths. The code here for joining paths is a little hacky.

</tbody>
</table>
</div>
</div>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering having this module dynamically create <input></input> snippets with the selected event, so this could be easily dropped into forms.

I think this component benefits most from being used as a component on a page. Otherwise it's a very poor replacement for all the features we have in the Globus Webapp.

@NickolausDS
Copy link
Collaborator Author

Closing this in favor of a newer react-based approach to a transfer selection UI created by @sturoscy-personal. Check out the sneak peak on the DGPF cookiecutter repo!

@NickolausDS NickolausDS deleted the collections branch May 26, 2022 15:44
NickolausDS added a commit to NickolausDS/django-globus-portal-framework that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant