fix: Remove un-used validate_token() function #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function isn't used internally anywhere, and is leftover from older functionality. Its use was discussed, and it's very much something we want to discourage for pretty much all use-cases (It's much better to assume a token is active and deal with it being revoked). This is an internal function, and more of a refactor, but labeling it a fix so it's noted in changenotes.
NickolausDS
force-pushed
the
remove-token-check
branch
from
d200438
to
20e59ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function isn't used internally anywhere, and is leftover from older functionality. Its use was discussed, and it's very much something we want to discourage for pretty much all use-cases (It's much better to assume a token is active and deal with it being revoked).
This is an internal function, and more of a refactor, but labeling it a fix so it's noted in changenotes.