New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added notification message and exception for starting a non-configured endpoint #435
Conversation
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 35.94% 33.29% -2.66%
==========================================
Files 20 20
Lines 2245 2607 +362
==========================================
+ Hits 807 868 +61
- Misses 1438 1739 +301
Continue to review full report at Codecov.
|
'2. Update the configuration\n' | ||
'3. Start the endpoint\n') | ||
print(msg) | ||
raise FileNotFoundError(f'Endpoint {name} is not configured!') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should probably keep the old style. No need to raise an exception here, and this exception seems irrelevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to raise a similar exception as
FileNotFoundError: [Errno 2] No such file or directory: '/home/zhuozhao/.funcx/test_local_1/config.py'
We can keep the old style.
5abfe4f
to
ba12731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Let's merge this.
For Issue #432
After the fix, when we try to start a non-configured endpoint
test-ep
: