Results Ack Sending

[knagaitsev]

Description

See funcx-faas/funcx-forwarder#27

Type of change

• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[codecov]

Codecov Report

Merging #571 (3ae96db) into main (fb9187c) will increase coverage by 0.03%.
The diff coverage is 39.65%.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   38.76%   38.80%   +0.03%     
==========================================
  Files          27       28       +1     
  Lines        2920     2974      +54     
==========================================
+ Hits         1132     1154      +22     
- Misses       1788     1820      +32     

Impacted Files	Coverage Δ
...ncx_endpoint/executors/high_throughput/executor.py	32.63% <0.00%> (-0.12%)	⬇️
...cx_endpoint/funcx_endpoint/endpoint/interchange.py	28.69% <20.00%> (-0.52%)	⬇️
...cx_endpoint/funcx_endpoint/endpoint/results_ack.py	50.00% <50.00%> (ø)
...ncx_endpoint/executors/high_throughput/messages.py	57.14% <50.00%> (-0.71%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9187c...3ae96db. Read the comment docs.

[yadudoc]

This is a bit confusing, maybe just log_period is sufficient.

[yadudoc]

This looks mostly good to go. I've added some comments where renaming the variables would improve clarity.

[yadudoc]

Okay, this looks good to go.

[knagaitsev]

[ch10083]

[shortcut-integration]

This pull request has been linked to Clubhouse Story #10083: Implement ACK as part of forwarder protocol.