New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same file by default for endpoint stdout/stderr and file logger #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Loonride, let's go simpler and write the logs to endpoint.log
. The user doesn't need to know what an EndpointInterchange is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is much cleaner!
b384840
to
c0c4b4f
Compare
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 39.13% 39.13%
=======================================
Files 31 31
Lines 3138 3138
=======================================
Hits 1228 1228
Misses 1910 1910
Continue to review full report at Codecov.
|
I just tested this, and it looks like it's working. @Loonride Convert over to PR? |
[ch10328] |
This pull request has been linked to Clubhouse Story #10328: Simplify endpoint logging. |
Description
Change functionality of endpoint logging such that it all appends to same file by default
Type of change