Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same file by default for endpoint stdout/stderr and file logger #582

Merged
merged 2 commits into from Sep 4, 2021

Conversation

knagaitsev
Copy link
Contributor

Description

Change functionality of endpoint logging such that it all appends to same file by default

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Collaborator

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Loonride, let's go simpler and write the logs to endpoint.log. The user doesn't need to know what an EndpointInterchange is.

@knagaitsev knagaitsev changed the title Some file by default for endpoint stdout/stderr and file logger Same file by default for endpoint stdout/stderr and file logger Aug 31, 2021
Copy link
Collaborator

@ryanchard ryanchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is much cleaner!

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #582 (c0c4b4f) into main (9b5d4d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   39.13%   39.13%           
=======================================
  Files          31       31           
  Lines        3138     3138           
=======================================
  Hits         1228     1228           
  Misses       1910     1910           
Impacted Files Coverage Δ
...x_endpoint/funcx_endpoint/endpoint/utils/config.py 100.00% <ø> (ø)
...dpoint/funcx_endpoint/endpoint/endpoint_manager.py 56.01% <100.00%> (ø)
...cx_endpoint/funcx_endpoint/endpoint/interchange.py 27.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5d4d8...c0c4b4f. Read the comment docs.

@yadudoc
Copy link
Collaborator

yadudoc commented Sep 2, 2021

I just tested this, and it looks like it's working. @Loonride Convert over to PR?

@yadudoc
Copy link
Collaborator

yadudoc commented Sep 3, 2021

[ch10328]

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #10328: Simplify endpoint logging.

@knagaitsev knagaitsev marked this pull request as ready for review September 3, 2021 16:18
@yadudoc yadudoc merged commit c9d9737 into main Sep 4, 2021
@yadudoc yadudoc deleted the ep_log_files branch September 4, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants