Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise result size limit to 10MB #647

Merged
merged 1 commit into from Dec 20, 2021

Conversation

sirosen
Copy link
Member

@sirosen sirosen commented Dec 17, 2021

And fix sys.getsizeof on a bytestring to use len instead.

I've also updated tests which generated 550KB of data (exceeding the 512KB limit) to generate 11MB of data. This should generate the same error before and after the update. It therefore will keep smoke tests working when the tutorial endpoint is updated, for example.

And fix `sys.getsizeof` on a bytestring to use `len` instead.
@sirosen sirosen requested a review from yadudoc December 17, 2021 16:53
@sirosen
Copy link
Member Author

sirosen commented Dec 17, 2021

[sc-12028]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12028: Update size limit for results.

Copy link
Collaborator

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@sirosen sirosen merged commit ee50857 into globus:main Dec 20, 2021
@sirosen sirosen deleted the raise-result-size-limit branch December 20, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants