Transfer fixes #73
Merged
Transfer fixes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some duplicate transfer submission error checking to re-use the standard GCS Auth class, which can catch a wider swath of errors that can come back from various GCS endpoints. Also, Transfer Submissions previously weren't handling 401s correctly by not passing exception info. This has been fixed by removing the old code and replacing it withh the GCS class above.
sturoscy-personal
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some duplicate transfer submission error checking to re-use
the standard GCS Auth class, which can catch a wider swath of errors
that can come back from various GCS endpoints.
Also, Transfer Submissions previously weren't handling 401s correctly
by not passing exception info. This has been fixed by removing the
old code and replacing it with the GCS class above.