Add filter_is_error to advanced task event list #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The param is added as a bool. However, testing covers setting it as an int. This is the usage which was seen in the wild under SDK v2.x which prompted this addition, and checking that it is supported (although not documented and not to be encouraged) is simple enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported this parameter missing in 3.0b4. It's a casualty of the
**params=>query_params={...}passthrough change, so this adds it as an explicit parameter.The param is added as a bool. However, testing covers setting it as an int. This is the usage which was seen in the wild under SDK v2.x which prompted this addition, and checking that it is supported (although not documented and not to be encouraged) is simple enough.