Add support for AuthClient.get_identity_providers #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
This has been tested with multiple authentication types and supports more than just client creds. Therefore, it is defined on the base class, alongside `get_identities`. `get_identity_providers` is a relatively small GET API which was missing from the SDK's clients.
sirosen
force-pushed
the
add-auth-identity-provider-apis
branch
from
4d25654
to
06e9050
Compare
kurtmckee
requested changes
Jun 21, 2023
tests/functional/services/auth/base/test_get_identity_providers.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
sirosen
changed the title
kurtmckee
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background / context:
At some point, the AuthClient and its subclasses started to slip behind the APIs which are documented at docs.globus.org . To heal this, start filling in the gaps.
This has been tested with multiple authentication types and supports more than just client creds. Therefore, it is defined on the base class, alongside
get_identities.get_identity_providersis a relatively small GET API which was missing from the SDK's clients.馃摎 Documentation preview 馃摎: https://globus-sdk-python--757.org.readthedocs.build/en/757/