Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate_flow operation to FlowsClient #979

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

ada-globus
Copy link
Contributor

@ada-globus ada-globus commented Apr 22, 2024

I added a quick copyedit commit to normalize capitalization of "flow" and "run", which appeared to be inconsistent. It's not per se part of the scope, but was very fast and relevant to matching the new docstring for validate_flow. If it's a significant barrier to getting this merged, I can break it into a separate PR.


📚 Documentation preview 📚: https://globus-sdk-python--979.org.readthedocs.build/en/979/

Signed-off-by: Ada <ada@globus.org>
Signed-off-by: Ada <ada@globus.org>
@@ -46,14 +46,14 @@ def create_flow(
additional_fields: dict[str, t.Any] | None = None,
) -> GlobusHTTPResponse:
"""
Create a Flow
Create a flow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a style-guide for this. We started using emphasis (boldface, IIRC?) in some of the docs for flow, run, timer, and other proper nouns which are easily confused with service names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the way I'd phrase it is roughly:

Entities (e.g., flow, run, action, action provider) are lowercase and first appearance is set off as a "term" in whatever paradigm a given document uses; for the docs site, we use bold

Is there such a paradigm—or related prior-art—in the SDK docs? If so, happy to make consistent!

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to hold this change until there's a Flows service release to put that validate route out there. When the SDK or CLI "run ahead", it produces a slightly strange situation if we release.

@@ -46,14 +46,14 @@ def create_flow(
additional_fields: dict[str, t.Any] | None = None,
) -> GlobusHTTPResponse:
"""
Create a Flow
Create a flow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a style-guide for this. We started using emphasis (boldface, IIRC?) in some of the docs for flow, run, timer, and other proper nouns which are easily confused with service names.

@ada-globus
Copy link
Contributor Author

@sirosen Yeah, wasn't planning to merge til the Flows release hits next week—and CLI will be prepped for when that occurs :)

@ada-globus ada-globus merged commit 9530da4 into main Apr 25, 2024
30 checks passed
@ada-globus ada-globus deleted the an/add-validate-route-to-flows-client/sc-33101 branch April 25, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants