Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor possible improvements #1

Closed
tizzen33 opened this issue Mar 10, 2021 · 2 comments
Closed

Some minor possible improvements #1

tizzen33 opened this issue Mar 10, 2021 · 2 comments

Comments

@tizzen33
Copy link

First of all, thanks a lot for creating this awesome app. It works fine and incredibly fast on Proximus' Android TV decoder (v7).

A few improvements that would make the experience even better:

  • When I press the 'stop' button, the episode stops but the screen stays black until I use the 'back' button.
  • It's not possible to rewind or fast forward with the buttons on the remote. It does work if I select the rewind or fast forward icons on the screen.
  • When I pause and resume an episode, the overlay stays visible until the 'back' button is pressed.

That's it.

Thanks again
tizzen

glorang added a commit that referenced this issue Mar 15, 2021
@glorang
Copy link
Owner

glorang commented Mar 15, 2021

Thanks for your feedback, much appreciated. The video player controls were indeed one of the things that still needed improvement.

I've released v1.1.6 in the beta channel on Google Play, it should become available within the next 45 minutes or so.
It should fix at least the "Stop" issue and improve the rewind / fast forward (a lot), but possibly not yet with the rewind / forward buttons on your remote.

I'll need to check how to reproduce, neither Chromecast and TADAAM remote have separate forward/rewind/play/stop buttons, they all stick to D-PAD only.

Lastly, the overlay issue seems a bug in the Leanback library, I've implemented some code that should fix it but doesn't seem to work here so far. Might need some more investigation.

@glorang
Copy link
Owner

glorang commented Apr 18, 2021

I've released 1.2.2 yesterday night, all issues reported here should be fixed now.

Can you check if you received the updated version (Settings > About) and let me know if everything works with your remote as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants