Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle output #72

Merged
merged 2 commits into from Jan 21, 2021
Merged

Fix bundle output #72

merged 2 commits into from Jan 21, 2021

Conversation

rafaelcamargo
Copy link
Member

Issues

  1. React bundle was not been generated properly (react-dom peer dependency was being required as ReactDOM in commonjs environment).
  2. Generated files were inside a dist folder. It was very uncomfortable to add /dist on import path (eg.: import { Button } from '@glorious/taslonic/dist/react').

Solution

  1. Fixed the external Webpack config attribute to support different peer dependency names according enviroment.
  2. Files are now available at the root of library directory (eg.: import { Button } from '@glorious/taslonic/react')

Links/Preview

N/A

@rafaelcamargo rafaelcamargo merged commit b1fe973 into master Jan 21, 2021
@rafaelcamargo rafaelcamargo deleted the bundle_fix branch January 21, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant