Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart Null Safety Compatibility #25

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Dart Null Safety Compatibility #25

merged 3 commits into from
Mar 29, 2021

Conversation

rayliverified
Copy link
Contributor

Fixes #24 , #22

@rayliverified
Update Dependencies
363e046
@rayliverified
Update Dart SDK v2.6.0
300e57d 
*Update to minimum supported Dart SDK.
@rayliverified
Dart Null Safety Compatibility
0377d3b 
*Fix throwsNull error.
callawey
callawey approved these changes Nov 27, 2020
View reviewed changes
Copy link

@callawey callawey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null Safety for throwNullError applied correctly

@tim232385
Copy link

please... fix it

@rayliverified
Copy link
Contributor Author

Can this PR be merged?

mohammadne
mohammadne approved these changes Dec 2, 2020
View reviewed changes
Copy link

@mohammadne mohammadne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null Safety for throwNullError applied correctly

@rayliverified
Copy link
Contributor Author

Merging is still blocked.
MaxthonSnap20201208101113

@GGuinea
Copy link

GGuinea commented Dec 9, 2020

Will be good to merge those changes :)

@nuno84
Copy link

nuno84 commented Dec 10, 2020

Up!

@rayliverified
Copy link
Contributor Author

There's more reviewers here than in Google's repo.
Can someone please help merge this PR?

pinpong
pinpong reviewed Dec 21, 2020
View reviewed changes
Copy link

@pinpong pinpong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CristianTorrado
CristianTorrado approved these changes Jan 30, 2021
View reviewed changes
Copy link

@CristianTorrado CristianTorrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good :) Thanks 👍

@rayliverified
Copy link
Contributor Author

Why is merging still blocked? Numerous people have reviewed this PR. I'll be closing this PR if it does not get merged soon.

@AyushBherwani1998
Copy link
Contributor

@searchy2 Only the member of organization or those who have write access to the repository can approve your request :(

@AyushBherwani1998
Copy link
Contributor

Hey @RockerFlower, can you please review this PR? Thanks :)

@ubuntudroid
Copy link

Shouldn't this now be fine to be merged?

@zjamshidi
Copy link

waiting for it

@danieramiz
Copy link

This plugin it's lost in space
abandoned!
6 months since the last update

@binSaed
Copy link

binSaed commented Mar 4, 2021

thank @searchy2 I used ur fork and it working good

  wave:
    git:
      url: git://github.com/searchy2/wave.git

HektorCyC
HektorCyC approved these changes Mar 11, 2021
View reviewed changes
Copy link

@HektorCyC HektorCyC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RockerFlower RockerFlower merged commit fb35007 into glorylab:master Mar 29, 2021
@RockerFlower
Copy link
Sponsor Member

@searchy2 @callawey @tim232385 @mohammadne @ashamnx @GGuinea @nuno84 @pinpong @npereira-jc @RaineCode178 @CristianTorrado @AyushBherwani1998 @rockar06 @ubuntudroid @zjamshidi @danieramiz @AbdOoSaed @danieramiz @HektorCyC @fgarcia92 @clirimfurriku

I am very sorry! Due to some personal matters, I haven't logged in to GitHub for a long time, which wasted your time. I will restart the maintenance of this plugin in the near future. Sorry again!

@ubuntudroid
Copy link

@RockerFlower no worries, after all this is a free (and open source) library and you are doing this in your spare time, so no need to be sorry! Instead, let me thank you for picking this up again. 🙏

@ashamnx
Copy link

ashamnx commented Mar 29, 2021

Welcome back and I hope everything is well now.

@RockerFlower RockerFlower requested review from RockerFlower and removed request for RockerFlower March 31, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinpong pinpong pinpong left review comments

@HektorCyC HektorCyC HektorCyC approved these changes

@callawey callawey callawey approved these changes

@ashamnx ashamnx ashamnx approved these changes

@danieramiz danieramiz danieramiz approved these changes

@rockar06 rockar06 rockar06 approved these changes

@CristianTorrado CristianTorrado CristianTorrado approved these changes

@clirimfurriku clirimfurriku clirimfurriku approved these changes

@npereira-jc npereira-jc npereira-jc approved these changes

@binSaed binSaed binSaed approved these changes

@fgarcia92 fgarcia92 fgarcia92 approved these changes

@GGuinea GGuinea GGuinea approved these changes

@mohammadne mohammadne mohammadne approved these changes

@RaineCode178 RaineCode178 RaineCode178 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on throwNullError