Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Megacomplex scale must be defined per dataset and per megacomplex #606

Closed
joernweissenborn opened this issue Mar 19, 2021 · 0 comments · Fixed by #612
Closed

Megacomplex scale must be defined per dataset and per megacomplex #606

joernweissenborn opened this issue Mar 19, 2021 · 0 comments · Fixed by #612
Assignees
@joernweissenborn
Labels
Priority: Medium Business as usual Status: Available Can be picked up to work on Type: Enhancement Feature requests

Comments

@joernweissenborn
Copy link
Member

Currently, a mega complex scale is applied to all dataset, but it must be per dataset
@jsnel jsnel added Priority: Medium Business as usual Status: Available Can be picked up to work on Type: Enhancement Feature requests labels Mar 20, 2021
joernweissenborn added a commit to joernweissenborn/pyglotaran that referenced this issue Mar 26, 2021
@joernweissenborn
Changed megacomplex scale application and definition.
c42a9c1 
Megacomplex scales are now a property of the dataset_descriptor. They
are defined per dataset per megacomplex.

Fixes glotaran#606
@joernweissenborn joernweissenborn mentioned this issue Mar 26, 2021
Merged
jsnel pushed a commit to joernweissenborn/pyglotaran that referenced this issue Mar 27, 2021
@joernweissenborn @jsnel
Changed megacomplex scale application and definition.
bd79d60 
Megacomplex scales are now a property of the dataset_descriptor. They
are defined per dataset per megacomplex.

Fixes glotaran#606
jsnel pushed a commit to joernweissenborn/pyglotaran that referenced this issue Mar 28, 2021
@joernweissenborn @jsnel
Changed megacomplex scale application and definition.
12817b1 
Megacomplex scales are now a property of the dataset_descriptor. They
are defined per dataset per megacomplex.

Fixes glotaran#606
@jsnel jsnel linked a pull request Mar 28, 2021 that will close this issue
Fix several issues with KineticImage model #612
Merged
jsnel added a commit that referenced this issue Mar 28, 2021
@joernweissenborn @s-weigand @jsnel
Fix several issues with KineticImage model (#612)
b188047 
Fixes #604, #605, #606

Main features:
* Made Irf.normalize true by default and only normalize matrix when set. Closes #604
* When combinging k matrices, the right hand matrix now overwrites the left one. Closes #605
* Changed megacomplex scale application and definition. Closes #606
Megacomplex scales are now a property of the dataset_descriptor. They are defined per dataset per megacomplex.

Other commits:
* Fix unit test for combining k matrices
Accessing the matrix by key returns the parameter stored at that key, whereas in the test the full_label is used to test if combining worked.
* Fix typo associated in kinetic_*_result
Internal API only. User exposed attributes already had correct spelling of associated
* Update docstring for KMatrix.combine

Co-authored-by: Sebastian Weigand <s.weigand.phy@gmail.com>
Co-authored-by: Joris Snellenburg <jsnel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joernweissenborn joernweissenborn

Labels
Priority: Medium Business as usual Status: Available Can be picked up to work on Type: Enhancement Feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several issues with KineticImage model joernweissenborn/pyglotaran
2 participants
@joernweissenborn @jsnel