Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing files in packaging #227

Merged
merged 10 commits into from Nov 19, 2019
Merged

Fix missing files in packaging #227

merged 10 commits into from Nov 19, 2019

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 3, 2019 •
edited

Changes:

  • Included missing files in package see Fix missing files in packaging #226
  • Refreshed api_documentation.rst
  • Added doc refreshing to doc test
  • Made doc tests pass again
  • Made test output verbose

Not 100% sure if the changes I made in the docs are correct, but Sphinx did evaluate them and the building of the docs failed.

If all is fine, please make a new release on PyPi after the merge:

$ git pull
$ bumpversion patch
$ git push
$ git push --tags

Closing issues

closes #226

@s-weigand s-weigand added Priority Type: Tooling Tools used for the project (CI, CD, docs etc.) labels Nov 3, 2019
@s-weigand s-weigand mentioned this pull request Nov 3, 2019
Closed
joernweissenborn
joernweissenborn requested changes Nov 3, 2019
View reviewed changes
Copy link
Member

@joernweissenborn joernweissenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the test stays in. I am willing to pull it without the test removal since that is unrelated and you showed the build works without the broken test case.

@s-weigand
Copy link
Member Author

If the test stays in, travis will timeout and there will be no release made.
Which in turn means that i can't work on getting pyglotaran on conda-forge.
How about you revert commit 1779c48ac78500ddecd70717133d842e75f8ebe1 and work on it on feature branch?
This might also break parts of my doc fix, but I can single that changes out and make an extra PR.

@s-weigand
Copy link
Member Author

Reactivated the test

@joernweissenborn
Copy link
Member

@s-weigand we fixed master, can you rebase this PR?

@s-weigand
made doc tests generate new api docs before running the tests
079e963 
also refined the dependency installation to use pip on module scale to prevent possible problems on windows, due to locked pip executable
@s-weigand
added workflow job to tests if api docs are up to date
f317e93
@joernweissenborn joernweissenborn merged commit 8716195 into glotaran:master Nov 19, 2019
@s-weigand s-weigand deleted the fix-packaging branch November 19, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joernweissenborn joernweissenborn joernweissenborn approved these changes

Assignees

@joernweissenborn joernweissenborn

Labels
Type: Tooling Tools used for the project (CI, CD, docs etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix missing files in packaging
2 participants
@s-weigand @joernweissenborn