Performance Fixes #242
Merged
Performance Fixes #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 11, 2019 12:31
…s close to one Could lead to numerical issues sometimes
Added TODO reminder to make dask.dsitributed optional in optimize.py
use gh actions for testing
Fix small gh action errors
Updated timepoints and spectra to have more sensible values TODO: also test for kinetic peramters non-negative set to True
Since the data values approach zero the relative tolerance becomes unreliable especially when (e.g. due to platform/bit issues) values are capped at 1e-15 or 1e-30 when comparing data and fit absolute tolerance should be used when comparing fitted parameters there may be a case for relative tolerance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles performance issues with some Irf tests and spectral penalties.
Fixes #237
Fixes #238