Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize query arguments #394

Closed
vyasr opened this issue Aug 20, 2019 · 1 comment
Closed

Standardize query arguments #394

vyasr opened this issue Aug 20, 2019 · 1 comment

Comments

@vyasr
Copy link
Collaborator

vyasr commented Aug 20, 2019

Currently we instantiate QueryArgs in compute/accumulate methods in Cython and pass them through to C++. Defaults are determined by whatever defaults are specified inside these compute methods. We should have a more well-defined resolution order where defaults are specified and used consistently.

The best approach will be to store a class attribute dictionary for all such classes that contains default query arguments. If users provide default values, they are used, but must be complete. We should provide some level of query mode inference, so that users could provide query arguments that contain just r_max, for example, and have that automatically be a ball query. We should keep the mode argument available to support any future query modes that might lead to conflicts with this resolution, see #372 for example.

@bdice
Copy link
Member

bdice commented Aug 27, 2019

This is fixed in #395 and subsequent PRs.

@bdice bdice closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants