Remove features deprecated in v3.x. #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
requested review from
tommy-waltmann and
shihkual
and removed request for
a team
joaander
added
the
validate
tommy-waltmann
requested changes
Feb 16, 2023
tommy-waltmann
requested changes
Feb 16, 2023
tommy-waltmann
requested changes
Feb 16, 2023
hoomd/md/constrain.py
Outdated
| particle position and orientations in body coordinates (see `body`). Then, | ||
| `Rigid` takes control of the constituent particles and sets their position | ||
| and orientation in the simulation box relative to the position and | ||
| particles. For each rigid body particle type, you set the constituent |
There was a problem hiding this comment.
Suggested change
| particles. For each rigid body particle type, you set the constituent | |
| particles. For each rigid body particle type, set the constituent |
Try to stay away from using the word "you" in documentation if possible.
There was a problem hiding this comment.
OK, I did so in Rigid. Fixing the rest of the documentation is far beyond the scope intended for this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove features deprecated in v3.x.
Motivation and context
Follow through on our promise to remove these non-functional or not needed features.
How has this been tested?
I updated the CI tests and checked that the removed features are not present in the documentation.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.