Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more deprecated names. #1499

Merged
merged 3 commits into from Feb 17, 2023
Merged

Remove more deprecated names. #1499

merged 3 commits into from Feb 17, 2023

Conversation

joaander
Copy link
Member

Description

Remove msg_file and Gauss.

In #1497, I failed to notice that md.external.wall.Gauss. I doubt there are many users, so I will remove in v4 without a deprecation cycle in v3.

Motivation and context

See #1497.

How has this been tested?

I checked a local documentation build and did not see the removed quantities.

Change log

Added:

* ``hoomd.md.external.wall.Gaussian``

Removed:

* ``hoomd.md.pair.Gauss``
* ``hoomd.md.external.wall.Gauss``
* ``msg_file`` property and argument in ``hoomd.device.Device``.

Checklist:

@joaander
Remove msg_file.
394d92f 
This was replaced with message_filename.
@joaander
Remove Gauss.
cd2d155 
Replaced with Gaussian.
@joaander
Document changes in the migration guide.
e2f8a1f
@joaander joaander requested review from a team as code owners February 17, 2023 11:39
@joaander joaander requested review from b-butler and klywang and removed request for a team February 17, 2023 11:39
@joaander joaander added the validate Execute long running validation tests on pull requests label Feb 17, 2023
b-butler
b-butler approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@b-butler b-butler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@joaander joaander merged commit 3222982 into trunk-major Feb 17, 2023
@joaander joaander deleted the remove-more-deprecated-names branch February 17, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-butler b-butler b-butler approved these changes

@klywang klywang Awaiting requested review from klywang klywang is a code owner automatically assigned from glotzerlab/hoomd-reviewers

Assignees
No one assigned
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaander @b-butler