Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate _InternalCustomUpdater.update, _InternalCustomTuner.tune, and _InternalCustomWriter.write #1648

Closed
joaander opened this issue Nov 8, 2023 · 0 comments
Assignees
Labels
breaking Changes that will break API. good first issue Good for newcomers task Something needs to be done.

Comments

@joaander
Copy link
Member

joaander commented Nov 8, 2023

Description

In a branch off trunk-minor, add deprecation warnings for:

  • _InternalCustomUpdater.update.
  • _InternalCustomTuner.tune.
  • _InternalCustomWriter.write.
  • HDF5Log.write.

After this branch is merged, remove these methods in a branch off trunk-major.

Motivation and context

These methods are not logically consistent with the operations model in hoomd. Simulation is responsible for calling the operation's action at the appropriate time during the simulation loop. See #1588 (comment) for additional context.

@joaander joaander added task Something needs to be done. good first issue Good for newcomers breaking Changes that will break API. labels Nov 8, 2023
@melodyyzh melodyyzh self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Changes that will break API. good first issue Good for newcomers task Something needs to be done.
Projects
None yet
Development

No branches or pull requests

2 participants