Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GPUNotAvailableError to error.py. #1649

Closed
joaander opened this issue Nov 8, 2023 · 0 comments
Closed

Move GPUNotAvailableError to error.py. #1649

joaander opened this issue Nov 8, 2023 · 0 comments
Assignees
@melodyyzh
Labels
breaking Changes that will break API. good first issue Good for newcomers task Something needs to be done.

Comments

@joaander
Copy link
Member

joaander commented Nov 8, 2023

Description

In a branch off trunk-minor:

  • Import GPUNotAvailableError in error.py.
  • Note in the documentation that util.GPUNotAvailableError is deprecated and will move to error.

After this branch is merged, remove util.GPNotavailableError in a branch off `trunk-major.

Motivation and context

util should hold utility methods and error should hold error classes.
@joaander joaander added good first issue Good for newcomers task Something needs to be done. breaking Changes that will break API. labels Nov 8, 2023
@melodyyzh melodyyzh self-assigned this Dec 14, 2023
@melodyyzh melodyyzh mentioned this issue Jan 10, 2024
Merged
3 tasks
@melodyyzh melodyyzh mentioned this issue Jan 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melodyyzh melodyyzh

Labels
breaking Changes that will break API. good first issue Good for newcomers task Something needs to be done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaander @melodyyzh