Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect sometimes results in duplicated line data #610

Closed
disassembler opened this issue May 13, 2015 · 6 comments · Fixed by #770
Closed

Reconnect sometimes results in duplicated line data #610

disassembler opened this issue May 13, 2015 · 6 comments · Fixed by #770
Labels

Comments

@disassembler
Copy link

On occassion, glowing bear shows duplicate data. Android weechat app and tmux session of weechat don't show this. Screenshot attached. This is for comments, status messages, join/parts, etc...
screen shot 2015-05-13 at 11 29 17 am

@t3chguy
Copy link

t3chguy commented May 13, 2015

I've had this for regular messages too - logging out and back in solved it - but yeah +1

@lorenzhs lorenzhs added the bug label May 13, 2015
@lorenzhs
Copy link
Member

Yes, this sometimes happens after a reconnect. It seems like Glowing Bear reconnects twice, but we haven't figured out yet how that is even possible...

@lorenzhs
Copy link
Member

lorenzhs commented Aug 3, 2015

daurnimator suggested on IRC that this might be caused by registering the events on the same connection multiple times. We should look into that.

@lorenzhs lorenzhs changed the title Duplicate Line Data Reconnect sometimes results in duplicated line data Nov 28, 2015
@lorenzhs
Copy link
Member

lorenzhs commented Jan 8, 2016

'dancek' posted this on irc: http://i.imgur.com/rB1xlUj.png

@phime42
Copy link

phime42 commented Mar 6, 2016

Having this issue on a regular basis on iOS when leaving the GlowingBear Task open. Sometimes, messages are repeated 4 times.

@lorenzhs
Copy link
Member

lorenzhs commented Mar 7, 2016

Yeah, this happens with bad connections. I'll try to find some time to fix it soon, the problem is that we need a lock on the connection object. Shouldn't be too hard actually, but I've got plenty on my plate at the moment unfortunately. I promise to fix it for the next release though :)

Oh btw, a refresh of the page / restart of the app makes the issue go away for the moment. Ugly workaround? Yeah.

lorenzhs added a commit that referenced this issue Apr 10, 2016
This should fix #610 but needs more testing
lorenzhs added a commit that referenced this issue Apr 10, 2016
This should fix #610 but needs more testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants