Design light theme #434
Merged
Design light theme #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormier
force-pushed
the
design-light-theme
branch
from
3447978
to
133d2b2
Compare
torhve
force-pushed
the
design-light-theme
branch
2 times, most recently
from
9965bf1
to
1a3e676
Compare
cormier
force-pushed
the
design-light-theme
branch
2 times, most recently
from
9754be8
to
5642eb6
Compare
|
@cormier can you rebase please? |
cormier
force-pushed
the
design-light-theme
branch
2 times, most recently
from
4e32609
to
6f96f91
Compare
|
@lorenzhs : i've rebased. |
|
is it good to merge? |
|
It is ! |
|
Nice, I'll have a look later |
| <link href="css/glowingbear.css" rel="stylesheet" media="screen"> | ||
| <link href="css/themes/dark.css" rel="stylesheet" media="screen"> |
There was a problem hiding this comment.
is this still correct with the parametrised input in line 40?
* Remove style.css as those values should be themable as well. * Update urls in index.html to link to dark theme by default
* make the background lighter * set highlight colour to something readable * improve readability of default grey colours * make default text color readable * fix some base colours
cormier
force-pushed
the
design-light-theme
branch
from
6f96f91
to
3964fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423