Add support for Spring scheduled annotation

[gamefundas]

According to #416 support for @scheduled was added to spring plugin but I cant seem to find in the latest version of Glowroot.

Also adding the following didn't work for me. No errors in glowroot logs. config.json shows the instrumentation configuration appended at the end of the file.

{
"className": "",
"classAnnotation": "org.springframework.stereotype.Component",
"methodName": "",
"methodAnnotation": "org.springframework.scheduling.annotation.Scheduled",
"methodParameterTypes": [
".."
],
"captureKind": "transaction",
"transactionType": "Background",
"transactionNameTemplate": "Spring scheduled: {{this.class.simpleName}}#{{methodName}}",
"traceEntryMessageTemplate": "Spring scheduled: {{this.class.name}}.{{methodName}}()",
"timerName": "spring scheduled"
}

I must be missing something. Please advice.

[trask]

Hi @gamefundas, thanks for posting! It looks like I never added this to glowroot.

I will correct this, but first let's figure out why the above instrumentation isn't working for you.

Can you confirm that your class is annotated with @org.springframework.stereotype.Component and that your method (in that class) is annotated with @org.springframework.scheduling.annotation.Scheduled?

And also just want to confirm that you hit "Apply changes without restart" or restarted, and there's no "Spring scheduled: ..." transactions in the left-hand sidebar under Background transactions?

Thanks,
Trask

[gamefundas]

@trask my bad on the manual configuration. Was using a Service class so changing from Component to Service did the trick. But yea I guess this can be bundled along with the spring plugin and can apply to Spring component, service and event controller/rest controller.

Appreciate your quick response on this.

Thanks
Andy

[trask]

Hi @gamefundas, this should be available now in the latest snapshot release glowroot-agent-0.13.0-SNAPSHOT-dist.zip.

[gamefundas]

Tested, works fine. Thx @trask

[trask]

👍