Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view in trace entries overview #71

Closed
rolandkool opened this issue Feb 25, 2016 · 6 comments
Closed

Tree view in trace entries overview #71

rolandkool opened this issue Feb 25, 2016 · 6 comments
Milestone

Comments

@rolandkool
Copy link

Hi,

Currently, the trace entries may contain (depending on your app ofcourse) 100s of lines. Would it be possible to support a tree view there as well to get a better overview of the flow. Indentation size should be based on time it takes to process the call/trace entry.
The async calls could be tricky.
The pinpoint APM (https://github.com/naver/pinpoint) does a nice job of creating such a timeline.

@trask
Copy link
Member

trask commented Feb 28, 2016

Hi, thanks for the submitting this. I'm trying out some UI options locally. What do you think of something like this? (with hover over on the bars for exact timing info)

image

@trask trask added this to the v0.9 milestone Feb 28, 2016
@rolandkool
Copy link
Author

Hi, that overview looks better yes. In this example you can quickly see what is taking time, so that is good.
Our main app uses a lot of Async calls, how would these show up in such a flow diagram?
If it is possible to put this trace overview behind a configuration option in the code, I can check it out against our application and provide some better feedback.
Thanks.

@trask
Copy link
Member

trask commented Mar 1, 2016

That would be great. I'll post back, should be able to push something to master in another day that you can try out.

trask added a commit that referenced this issue Mar 2, 2016
@trask
Copy link
Member

trask commented Mar 2, 2016

@trask
Copy link
Member

trask commented Mar 4, 2016

This new graphical view is what made me notice #79 :-)

@trask
Copy link
Member

trask commented Mar 7, 2016

Thanks for this suggestion as well

@trask trask closed this as completed Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants