Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jedis plugin #68

Closed
wants to merge 1 commit into from
Closed

Add Jedis plugin #68

wants to merge 1 commit into from

Conversation

ajdevries
Copy link
Contributor

  • Tests are failing and I don't know why, tested with a real app and that is working;
  • Next commit will be pub/sub support and maybe upcoming API change

@trask trask closed this in 8d3e96f Feb 22, 2016
@trask
Copy link
Member

trask commented Feb 22, 2016

Thanks, this is now merged. The issue with the tests was that the jedis pointcut is a trace-entry (as opposed to a transaction) and so without an over-arching transaction, they don't get captured. TransactionMarker is the easiest way to provide an over-arching transaction for tests.

@trask trask added this to the v0.9 milestone Feb 27, 2016
@trask trask added the plugin label Feb 27, 2016
@trask trask changed the title Add start of Jedis plugin Add Jedis plugin Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement plugin
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajdevries @trask